Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the locate db more reliably #2889

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

paulapatience
Copy link

Previously it would be updated only if a file (or directory) named
~/.Private existed.

  • counsel.el (counsel--locate-updatedb): Replace spurious reference to
    ~/.Private with the file-name-directory of counsel-locate-db-path.

Previously it would be updated only if a file (or directory) named
~/.Private existed.

* counsel.el (counsel--locate-updatedb): Replace spurious reference to
~/.Private with the file-name-directory of counsel-locate-db-path.
@basil-conto
Copy link
Collaborator

basil-conto commented Jul 10, 2021

Thanks for looking into this!

Replace spurious reference to ~/.Private with the file-name-directory of counsel-locate-db-path.

However, commit b2693d1 that introduced this feature makes it look like the hard-coded ~/.Private was intentional, presumably something specific to @abo-abo's local setup. So I wouldn't be comfortable changing it without comment from @abo-abo. Furthermore, it doesn't look like counsel-locate-db-path and ~/.Private are meant to be the same thing, but then I'm not familiar with this part of Counsel.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants